Merge pull request #616 from marner2/feature/notify_when_HasErrors_ch…

…anges

Notify OnPropertyChanged when HasErrors changes

RELEASE_NOTES.md

@@ -1,3 +1,6 @@
+#### 4.0.0-beta-56
+* Add NotifyPropertyChanged for the HasErrors property.
+
 #### 4.0.0-beta-55
 * Add TwoWayT bindings for workflows that reuse bindings.
 * Add OneWayToSeqT bindings.

src/Elmish.WPF.Tests/DynamicViewModelTests.fs

@@ -844,6 +844,26 @@ module TwoWayValidate =
     }
 
 
+  [<Fact>]
+  let ``when model is updated, should trigger NotifyPropertyChanged on HasErrors iff the value returned by validate changes`` () =
+    Property.check <| property {
+      let! name = GenX.auto<string>
+      let! m1 = GenX.auto<int>
+      let! m2 = GenX.auto<int>
+
+      let get _ = ()
+      let set _ _ = ()
+      let validate m = if m < 0 then ValueSome (string m) else ValueNone
+
+      let binding = twoWayValidate name get set validate
+      let vm = TestVm(m1, binding)
+
+      vm.UpdateModel m2
+
+      test <@ vm.NumPcTriggersFor "HasErrors" = if (validate m1 |> ValueOption.isNone) = (validate m2 |> ValueOption.isNone) then 0 else 1 @>
+    }
+
+
   [<Fact>]
   let ``when validate returns ValueNone, HasErrors should return false and GetErrors should return an empty collection`` () =
     Property.check <| property {

src/Elmish.WPF/Elmish.WPF.fsproj

@@ -18,7 +18,7 @@
     <PackageProjectUrl>https://github.com/elmish/Elmish.WPF</PackageProjectUrl>
     <PackageTags>WPF F# fsharp Elmish Elm</PackageTags>
     <PackageIcon>elmish-wpf-logo-128x128.png</PackageIcon>
-    <Version>4.0.0-beta-55</Version>
+    <Version>4.0.0-beta-56</Version>
     <PackageReleaseNotes>https://github.com/elmish/Elmish.WPF/blob/master/RELEASE_NOTES.md</PackageReleaseNotes>
     <PackageReadmeFile>README.md</PackageReadmeFile>
     <!--Turn on warnings for unused values (arguments and let bindings) -->

src/Elmish.WPF/ViewModels.fs

@@ -177,8 +177,10 @@ type [<AllowNullLiteral>] internal DynamicViewModel<'model, 'msg>
     member _.CurrentModel : 'model = helper.Model
 
     member _.UpdateModel (newModel: 'model) : unit =
+      let prevHasErrors = (helper :> INotifyDataErrorInfo).HasErrors
       let eventsToRaise = ViewModelHelper.getEventsToRaise newModel helper
       helper <- { helper with Model = newModel }
+      let eventsToRaise = if prevHasErrors = (helper :> INotifyDataErrorInfo).HasErrors then eventsToRaise else (PropertyChanged "HasErrors") :: eventsToRaise
       ViewModelHelper.raiseEvents eventsToRaise helper
 
   override _.TryGetMember (binder, result) =