Simplify the logo text customization #71
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vnxme
force-pushed
the
custom-logo-text
branch
from
b8888fa to
ed3b8d8
Compare
vnxme
force-pushed
the
custom-logo-text
branch
from
ed3b8d8 to
5a75108
Compare
mhaseebliaqat
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed that many forks change the logo text or even eliminate this alteration at all. But I understand you would like to keep your e-mail and the repository address to distinguish the patched software versions from the original ones.
This PR simplifies the logo text customization. Once merged, you would have to add
CUSTOM_LOGO_TEXTwith[email protected] https://github.com/elseif/MikroTikPatchvalue to the list of secrets. Anyone using your repository for one's own purposes may do the same if needed. No logo text customization is done unlessCUSTOM_LOGO_TEXThas any non-empty value.