Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ddfg add randc function #86

Merged
merged 6 commits into from
Aug 1, 2019
Merged

Conversation

xyz8983
Copy link
Contributor

@xyz8983 xyz8983 commented Jul 31, 2019

This pull request is for addressing #67

  1. Add a function randc() to randomly generate data frame with categorical data, which are alphabetic characters. Extra characters combinations would be generated when the 26 characters are used up. (If number is desired, just leave a comment, I can update it)
  2. Update the Corruptor class to accept an extra attribute dtype with default value np.float, so the Corrupter class can generate dataset in other dtype, like np.string
  3. Add test cases for randc() function. One for BadInputError test, second for testing if the number of categories in the dataset is desired, third for testing if the shape of the dataset is desired.

Copy link
Owner

@eltonlaw eltonlaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. It looks good, just need to add the explicit cast to be compatible with 2.7.

impyute/dataset/base.py Show resolved Hide resolved
impyute/dataset/base.py Show resolved Hide resolved
impyute/dataset/base.py Outdated Show resolved Hide resolved
@eltonlaw eltonlaw merged commit 8569a8d into eltonlaw:master Aug 1, 2019
@eltonlaw
Copy link
Owner

eltonlaw commented Aug 1, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants