Update Mojang API response code and messages, implement UUID->Username endpoint #47
+236
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Octol1ttle
force-pushed
the
fix-mojang-api-responses
branch
2 times, most recently
from
0f3199a to
753fd07
Compare
Signed-off-by: Octol1ttle <[email protected]>
Octol1ttle
force-pushed
the
fix-mojang-api-responses
branch
from
ca82ee8 to
327dfee
Compare
erickskrauch
requested changes
Feb 24, 2025
There was a problem hiding this comment.
Для решения проблемы нарушения обратной совместимости, я предлагаю для старых урлов отвечать то, что отвечалось и раньше. Для новых - новое. А чтобы не дублировать контроллеры/экшены, я предложил бы использовать параметры запроса, указывая в rules роутера их через defaults (вот тут документация). Таким образом снаружи урлы будут безе параметров, а в экшен тебе будет приходить параметр, который позволит тебе понять, в каком формате давать ошибки.
Пожалуйста, не используй force push после ревью.
Signed-off-by: Octol1ttle <[email protected]>
…ing is broken)) Signed-off-by: Octol1ttle <[email protected]>
Signed-off-by: Octol1ttle <[email protected]>
Signed-off-by: Octol1ttle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates Mojang API responses to be in match with api.minecraftservices.com and adds a new endpoint