Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some development warnings #462

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

macabeus
Copy link
Contributor

@macabeus macabeus commented Dec 21, 2024

This PR fixes a couple of warnings when running the website.
I'm not fluent in Vue, but it seems to be running well.

[@vue/compiler-sfc] defineProps is a compiler macro and no longer needs to be imported"

The fix is just removing all the defineProps imports.

  • The second commit fixes this warning when rendering the /essential/validation.html page:

<tr> cannot be child of <table>

The fix is wrapping the <table> children with <tbody>. It seems that we already do it when building for production, but we need to explicitly write to do it in development mode too to suppress this warning.

The warning message is misleading btw (see vuejs/core#12088)

Cannot write file '/Users/macabeus/elysiajs/documentation/postcss.config.js' because it would overwrite input file.ts
Cannot write file '/Users/macabeus/elysiajs/documentation/tailwind.config.js' because it would overwrite input file.ts

The fix is including these files in the exclude property from tsconfig.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant