Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use original name instead of yet another temp file #37

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

zilti
Copy link

@zilti zilti commented Nov 25, 2020

Use the original file name (since that is, according to the docstring, what phpstan-normalize-path wants) instead of creating yet another temporary file that will confuse interpreters etc.

Use the original file name (since that is, according to the docstring, what `phpstan-normalize-path` wants) instead of creating yet another temporary file that will confuse interpreters etc.
@zonuexe
Copy link
Member

zonuexe commented Nov 26, 2020

@zilti Thank you. However, this patch is not accepted because the analysis results will not be displayed unless the file is saved. Please suggest another method.

@zilti
Copy link
Author

zilti commented Dec 3, 2020

Well, I don't know enough about the Flycheck internals. But my alternative suggestion would be to have both be temp files outside the original file's directory. At that point the question is why this extra roundtrip to some custom function is needed in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants