fix(rustic-babel-build-sentinel): align behaviour with other lang #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In an org file, the src block's code should be interpreted, OR the binary compiled from it SHOULD execute with PWD as `default-directory` of the org file. Summary of changes: 1. save the original default-directory then later restores it. 2. supply `--manifest-path` option to `cargo run` to execute the target `Cargo.toml` binary compiled from the src block. For reference: Try to execute a C++, C, js (node), python block. In particular, see implementation of `org-babel-C-execute` or `org-babel-python-evaluate-external-process`. May be we can re-write like them in the future. fixes: brotzeit/rustic#509
|
Probably this PR can be rebased and then merged if the CI passes ? |
|
Yes, it should be able to merged if the conflicts can be resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original description from @ed9w2in6 in brotzeit/rustic#535 :
In an org file, the src block's code should be interpreted, OR the binary compiled from it SHOULD execute with PWD as
default-directoryof the org file.Summary of changes:
--manifest-pathoption tocargo runto execute the targetCargo.tomlbinary compiled from the src block.For reference:
Try to execute a C++, C, js (node), python block.
In particular, see implementation of
org-babel-C-executeororg-babel-python-evaluate-external-process. May be we can re-write like them in the future.fixes: brotzeit/rustic#509