feat(logging): add timestamp to logs

SDK-223 Co-authored-by: davidSchuppa <[email protected]>
emartech · Feb 4, 2025 · d123a3c · d123a3c
1 parent 8d12fc0
commit d123a3c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/Sources/Core/Log/EMSLogger.m b/Sources/Core/Log/EMSLogger.m
@@ -14,6 +14,7 @@
 #import "EMSWrapperChecker.h"
 #import "EMSStorageProtocol.h"
 #import "EMSMethodNotAllowed.h"
+#import "NSDate+EMSCore.h"
 
 @interface EMSLogger ()
 
@@ -77,6 +78,7 @@ - (void)log:(id <EMSLogEntryProtocol>)entry
                         NSMutableDictionary *mutableData = [entry.data mutableCopy];
                         mutableData[@"level"] = [weakSelf logLevelStringFromLogLevel:level];
                         mutableData[@"queue"] = currentQueue;
+                        mutableData[@"timestamp"] = [NSString stringWithFormat:@"%@",[[self.timestampProvider provideTimestamp] numberValueInMillis]];
                         if (![weakSelf.wrapperChecker.wrapper isEqualToString:@"none"]) {
                             mutableData[@"wrapper"] = weakSelf.wrapperChecker.wrapper;
                         }

diff --git a/Tests/CoreTests/Log/EMSLoggerTests.m b/Tests/CoreTests/Log/EMSLoggerTests.m
@@ -16,6 +16,7 @@
 #import "EMSStorageProtocol.h"
 #import "EmarsysTestUtils.h"
 #import "EMSMethodNotAllowed.h"
+#import "NSDate+EMSCore.h"
 
 @interface EMSLoggerTests : XCTestCase
 
@@ -217,7 +218,8 @@ - (void)testLogShouldInsertEntryToShardRepository {
     OCMVerify([partialMockRepository add:[self shardWithLogLevel:LogLevelError
                                                   additionalData:(@{
                                                           @"queue": @"testRunnerQueue",
-                                                          @"wrapper": @"testWrapper"
+                                                          @"wrapper": @"testWrapper",
+                                                          @"timestamp": ([NSString stringWithFormat:@"%@",[self.timestamp numberValueInMillis]])
                                                   })]]);
 }
 
@@ -378,6 +380,7 @@ - (void)testShouldLog_whenLogLevelOfLogEntry_isBelowOfLogLevel_butIsAppStartLog
     mutableData[@"level"] = @"INFO";
     mutableData[@"queue"] = @"testRunnerQueue";
     mutableData[@"wrapper"] = @"testWrapper";
+    mutableData[@"timestamp"] = [NSString stringWithFormat:@"%@",[self.timestamp numberValueInMillis]];
 
     OCMVerify([partialMockRepository add:[[EMSShard alloc] initWithShardId:self.shardId
                                                                       type:@"app:start"
@@ -429,6 +432,7 @@ - (void)testLogLevel_useDBSafeDictionaryData {
     mutableData[@"level"] = @"INFO";
     mutableData[@"queue"] = @"testRunnerQueue";
     mutableData[@"wrapper"] = @"testWrapper";
+    mutableData[@"timestamp"] = [NSString stringWithFormat:@"%@",[self.timestamp numberValueInMillis]];
 
     OCMVerify([partialMockRepository add:[[EMSShard alloc] initWithShardId:self.shardId
                                                                       type:@"testTopic"