STM32F0/F3 Remap DMA channels #3653
Open
+71
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I fixed the merge conflict. Please let me know if there's anything left to accept this PR. I'm happy to implement feedback! The CI fails because it depends on a change in stm32-data. |
Dirbaio
reviewed
Jan 1, 2025
| if remap { | ||
| quote! { (#cfgr1 as *mut u32).write((#cfgr1 as *mut u32).read() | 1 << #bit_offset) } | ||
| } else { | ||
| quote! { (#cfgr1 as *mut u32).write((#cfgr1 as *mut u32).read() & !(1 << #bit_offset)) } |
There was a problem hiding this comment.
could you make this use the PAC to do the register writes, like all the other build.rs-generated code? pac::SYSCFG.cfgr1().modify(|w| w.set_whatever(val))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3643
I'm not sure if this is the most elegant way to retrieve the byte and bit offset of
SYSCFG.CFGR1and do the pointer arithmetic. I'm happy to receive feedback!Tested on STM32F072CB with I2C1.
Depends on embassy-rs/stm32-data#548