Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

complete adding download button #43

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

SaitejaUtpala
Copy link

@SaitejaUtpala SaitejaUtpala commented Sep 16, 2024

This PR download buttons for (#42 )

image

some comments

  • download is only enabled after voting is done.
  • current only done for retrieval task.

@SaitejaUtpala
Copy link
Author

@Muennighoff

Copy link
Contributor

@Muennighoff Muennighoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I'm unsure whether we need this functionality for the Anonymous and Side-by-side windows but maybe only for the Single window? @sivareddyg maybe you could chime in as you requested this feature I think?

ui.py Outdated Show resolved Hide resolved
ui.py Outdated Show resolved Hide resolved
ui.py Outdated Show resolved Hide resolved
ui.py Outdated Show resolved Hide resolved
ui.py Outdated Show resolved Hide resolved
SaitejaUtpala and others added 5 commits November 5, 2024 19:29
Co-authored-by: Niklas Muennighoff <[email protected]>
Co-authored-by: Niklas Muennighoff <[email protected]>
Co-authored-by: Niklas Muennighoff <[email protected]>
Co-authored-by: Niklas Muennighoff <[email protected]>
@SaitejaUtpala
Copy link
Author

@Muennighoff addressed PR review comments

@sivareddyg
Copy link
Member

@SaitejaUtpala This is great, thank you! can I see a live preview of the page with these modifications?

Downloading the embedding is one thing, but it would also be useful to provide some helper code on how to use the resulting embedding. Can you also provide an example on how to use the resulting embedding to compute cosine similarity and plot them in a TSNE plot. This could be in the form of toggle button.

This would attract people to come to arena to do other things. For example, many times, I want just download a few embeddings and play with them myself but without having to run the actual models on my machine, and this would make it super easy.

@SaitejaUtpala
Copy link
Author

@SaitejaUtpala This is great, thank you! can I see a live preview of the page with these modifications?

Downloading the embedding is one thing, but it would also be useful to provide some helper code on how to use the resulting embedding. Can you also provide an example on how to use the resulting embedding to compute cosine similarity and plot them in a TSNE plot. This could be in the form of toggle button.

This would attract people to come to arena to do other things. For example, many times, I want just download a few embeddings and play with them myself but without having to run the actual models on my machine, and this would make it super easy.

@sivareddyg On it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants