This repository has been archived by the owner on Feb 4, 2025. It is now read-only.
Removed debug code in refresh.py intended to only update one board #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I additionally removed types from docstring (some were lying) and added types where I could guess them to make it easier to debug the code in the future. Also added a minor description to the readme for ease of navigation.
orionw
approved these changes
Jul 28, 2024
There was a problem hiding this comment.
Thanks for noticing the discussion on the HF page and providing the fix! That one slipped by the CI since it didn't fail :/ at some point I suppose we could add a test to check that common models are present or something.
Looks great to me though, I'll merge it so it can start re-processing.
|
Not sure if it was this PR but the other tabs in the LB are broken since the last update (https://huggingface.co/spaces/mteb/leaderboard) 🤔 : 
|
|
I've fixed it in #21, but I don't understand what caused it |
|
Did it auto-fix with the newest update? I don't see it. |
|
Yes, It was fixed in 9e998d9 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I additionally removed types from the docstring (some were lying) and added types where I could guess them to make it easier to debug the code in the future. I also formatted using Ruff (the same thing we use on mteb).
Also added a minor description to the readme for ease of navigation.
Edit: I also resolved a revealed bug where it couldn't write to JSON due to a column (paws-x) being present twice.
Fixes #19