This repository has been archived by the owner on Dec 10, 2024. It is now read-only.
CI: test ember 2.18.2, use lts node in travis, yarn #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NOTE: not sure if using yarn in ember try is acceptable to you guys,
but it does speed up local testing quite a bit.
Turbo87
reviewed
Jul 3, 2018
| @@ -1,7 +1,6 @@ | |||
| --- | |||
| language: node_js | |||
| node_js: | |||
| - "4" | |||
| node_js: lts/carbon | |||
There was a problem hiding this comment.
Carbon is Node 8, but we still support Node 6 as the minimum. Actually we even support Node 4 with the current release. If we drop support that would be a breaking change and we should adjust the support declaration in the package.json file.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE:
not sure if using yarn in ember try is acceptable to you guys,
but it does speed up local testing quite a bit.