Merge pull request #120 from bertdeblock/various-improvements

Various minor improvements
ember-engines · Jul 22, 2021 · 3caa456 · 3caa456
2 parents 10395bc + 643ad5d
commit 3caa456
Show file tree

Hide file tree

Showing 6 changed files with 38 additions and 62 deletions.
diff --git a/tests/dummy/app/templates/docs/deprecations.md b/tests/dummy/app/templates/docs/deprecations.md
@@ -13,41 +13,31 @@ Before:
 ```js
 export default class App extends Application {
   // ...
-  constructor() {
-    super(...arguments);
-
-    this.engines = {
-      'super-blog': {
-        dependencies: {
-          services: [
-            'router',
-          ]
-        }
+  engines = {
+    'super-blog': {
+      dependencies: {
+        services: [
+          'router'
+        ]
       }
     }
   }
 }
-
 ```
 
 After:
 
 ```js
 export default class App extends Application {
   // ...
-  constructor() {
-    super(...arguments);
-
-    this.engines = {
-      'super-blog': {
-        dependencies: {
-          services: [
-            { 'host-router': 'router' }
-          ]
-        }
+  engines = {
+    'super-blog': {
+      dependencies: {
+        services: [
+          { 'host-router': 'router' }
+        ]
       }
     }
   }
 }
-
 ```
diff --git a/tests/dummy/app/templates/docs/links.md b/tests/dummy/app/templates/docs/links.md
@@ -67,16 +67,12 @@ import Application from '@ember/application';
 
 export default class App extends Application {
   // ...
-  constructor() {
-    super(...arguments);
-
-    this.engines = {
-      'super-blog': {
-        dependencies: {
-          externalRoutes: {
-            home: 'home.index',
-            settings: 'settings.blog.index'
-          }
+  engines = {
+    'super-blog': {
+      dependencies: {
+        externalRoutes: {
+          home: 'home.index',
+          settings: 'settings.blog.index'
         }
       }
     }

diff --git a/tests/dummy/app/templates/docs/quickstart.md b/tests/dummy/app/templates/docs/quickstart.md
@@ -134,7 +134,6 @@ Within your Engine's root directory, modify `index.js` so that your addon is con
 ```js
 // index.js
 
-/*jshint node:true*/
 const { buildEngine } = require('ember-engines/lib/engine-addon');
 
 module.exports = buildEngine({
@@ -152,7 +151,6 @@ Within your Engine's `config` directory, modify the `environment.js` file:
 ```js
 // config/environment.js
 
-/*jshint node:true*/
 'use strict';
 
 module.exports = function(environment) {

diff --git a/tests/dummy/app/templates/docs/services.md b/tests/dummy/app/templates/docs/services.md
@@ -21,17 +21,13 @@ This means that your Engine will expect the host application to provide both the
 // dummy/app/app.js
 export default class App extends Application {
   // ...
-  constructor() {
-    super(...arguments);
-
-    this.engines = {
-      'super-blog': {
-        dependencies: {
-          services: [
-            'store',
-            { 'session': 'user-session' }
-          ]
-        }
+  engines = {
+    'super-blog': {
+      dependencies: {
+        services: [
+          'store',
+          { 'session': 'user-session' }
+        ]
       }
     }
   }

diff --git a/tests/dummy/app/templates/docs/testing-acceptance.md b/tests/dummy/app/templates/docs/testing-acceptance.md
@@ -66,14 +66,12 @@ import Application from '@ember/application';
 
 export default class App extends Application {
   // ...
-  constructor() {
-    super(...arguments);
-
-    this.engines = {
-      'admin-engine': {
-        dependencies: {
-          services: ['location-service']
-        }
+  engines = {
+    'admin-engine': {
+      dependencies: {
+        services: [
+          'location-service'
+        ]
       }
     }
   }
@@ -132,14 +130,12 @@ import Application from '@ember/application';
 
 export default class App extends Application {
   // ...
-  constructor() {
-    super(...arguments);
-
-    this.engines = {
-      'admin-engine': {
-        dependencies: {
-          externalRoutes: ['home']
-        }
+  engines = {
+    'admin-engine': {
+      dependencies: {
+        externalRoutes: [
+          'home'
+        ]
       }
     }
   }

diff --git a/tests/dummy/app/templates/index.hbs b/tests/dummy/app/templates/index.hbs
@@ -37,7 +37,7 @@
 <div class="docs-bg-white">
   <div class="docs-container docs-md">
     <section class="docs-max-w-md docs-mx-auto docs-pb-8">
-      <aside>Looking for the quickstart? {{#docs-link "docs.index"}}Click here{{/docs-link}}.</aside>
+      <aside>Looking for the quickstart? {{#docs-link "docs.quickstart"}}Click here{{/docs-link}}.</aside>
 
       <h1 id="introduction">Introduction</h1>
       <p>Welcome to the official guide for Ember Engines! This guide is intended to get you up and running with Engines as implemented in the <a href="https://www.npmjs.com/package/ember-engines"><code>ember-engines</code></a> addon and give you background on various concepts and ideas related to Engines. It is intended to be read from start to finish, but has been broken down in case you want to come back and re-read a specific topic.</p>