Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing bower #126

Merged
merged 2 commits into from
Feb 18, 2019
Merged

Conversation

kaermorchen
Copy link
Contributor

I moved bourbon and neat from bower packages to npm packages and removed bower from project.

But I am not sure how will the tests work.

@kaermorchen
Copy link
Contributor Author

kaermorchen commented Aug 25, 2018

bash <(curl -s https://codecov.io/bash)00:00
Exit code: 2

#!/bin/bash -eo pipefail
bash <(curl -s https://codecov.io/bash)

/dev/fd/63: line 1: syntax error near unexpected token `newline'
/dev/fd/63: line 1: `<!DOCTYPE html>'
Exited with code 2

I don't understand what is wrong. How can I fix it?

@codecov-io
Copy link

codecov-io commented Aug 25, 2018

Codecov Report

Merging #126 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #126   +/-   ##
=======================================
  Coverage   76.17%   76.17%           
=======================================
  Files         101      101           
  Lines         810      810           
=======================================
  Hits          617      617           
  Misses        193      193

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72c6159...f0e6227. Read the comment docs.

@kategengler
Copy link
Member

The build failure was a flake.

Thanks for this. I'd like to hold off on merging it though, until #118 is completed; obviating the need for the bourbon-neat package. I'd also prefer to use https://github.com/yapplabs/ember-cli-bourbon to get bourbon into the project.

@kaermorchen
Copy link
Contributor Author

ember-cli-bourbon works with just version of bourbon gte 5

@kategengler kategengler force-pushed the feature/removing-bower branch from 4aa8422 to f0e6227 Compare February 18, 2019 02:02
@kategengler kategengler merged commit 2a5209e into emberobserver:master Feb 18, 2019
@kategengler
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants