Added percy integration #143
Conversation
Codecov Report
@@ Coverage Diff @@
## master #143 +/- ##
==========================================
+ Coverage 75.8% 79.15% +3.34%
==========================================
Files 102 102
Lines 806 806
==========================================
+ Hits 611 638 +27
+ Misses 195 168 -27
Continue to review full report at Codecov.
|
|
The naming convention I used for Percy snapshots feels a bit arbitrary and the placement of these new snapshots was a general good faith attempt. Please feel free to let me know if there's some other routes that are deserving of snapshots or if there's a better way to name them! |
tests/acceptance/addons-test.js
Outdated
| @@ -399,6 +403,9 @@ module('Acceptance: Addons', function(hooks) { | |||
|
|
|||
| test('can view a scoped addon with a / in the URL', async function(assert) { | |||
| await visit('/addons/@foo-bar/test-addon'); | |||
|
|
|||
| await percySnapshot('/addons/show'); | |||
There was a problem hiding this comment.
I think this should be in a different test that will have all the addon sections filled out?
There was a problem hiding this comment.
Right on, will update. Thanks!
|
Sounds great, thanks @kategengler ! |
- Replaced existing snapshot with two more detailed snapshots
yohanmishkin
force-pushed
the
tj/percy-install
branch
from
7b9fc69 to
2523c87
Compare
|
@kategengler I think this may be ready for a re-review. Let me know if I missed anything! |
|
Thanks for this!!! |
Percy is a visual testing tool designed to help catch regressions and reduce the amount of manual testing done in your application.
With Percy's recent introduction of a free plan and some important CSS changes planned for Ember Observer, Percy now makes a lot of sense.
This PR:
ember-percy, an ember addon used to easily integrate Percy into ember projectsNotes
ember-percyrepo is here.PERCY_TOKENhas already been added to the CI env so snapshots for master will hopefully just begin being taken once the PR merges.