Merge pull request #2261 from embroider-build/codemod-deduplication-bug

Fix bug in import deduplication in template-tag-codemod
embroider-build · Feb 11, 2025 · 5d79e14 · 5d79e14
2 parents 4d726b6 + f2c28ea
commit 5d79e14
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/packages/template-tag-codemod/src/index.ts b/packages/template-tag-codemod/src/index.ts
@@ -470,7 +470,10 @@ function renderScopeImports(scope: MetaResult['scope']) {
         sections.push(def[0]);
       }
 
-      let named = entries.filter(e => e[1] !== 'default');
+      // it's possible to have more than one local name for the default export,
+      // so this filter must only ignore the entry that we handled above, not
+      // any others that happen to use `default` as their imported name.
+      let named = entries.filter(e => e !== def);
       if (named.length > 0) {
         sections.push(
           '{' +