Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-plan prerelease #2259

Merged
merged 2 commits into from
Feb 11, 2025
Merged

release-plan prerelease #2259

merged 2 commits into from
Feb 11, 2025

Conversation

mansona
Copy link
Member

@mansona mansona commented Feb 11, 2025

This will currently produce the following release:

@embroider/addon-dev 9.0.0-alpha.0 (major)
@embroider/addon-shim 3.0.0-alpha.0 (major)
@embroider/broccoli-side-watch 1.2.0-alpha.0 (minor)
@embroider/compat 5.0.0-alpha.0 (major)
@embroider/config-meta-loader 2.0.0-alpha.0 (major)
@embroider/core 5.0.0-alpha.0 (major)
@embroider/hbs-loader 4.0.0-alpha.1 (minor)
@embroider/macros 3.0.0-alpha.0 (major)
@embroider/reverse-exports 0.1.2-alpha.0 (patch)
@embroider/router 4.0.0-alpha.0 (major)
@embroider/shared-internals 4.0.0-alpha.0 (major)
@embroider/template-tag-codemod 0.6.0-alpha.0 (minor)
@embroider/util 1.15.0-alpha.0 (minor)
@embroider/vite 2.0.0-alpha.0 (major)

Some points:

  • I would like to update release-plan to allow us to add alpha into the release names 👍 that's why this is currently a draft Done
  • I thought some things in this list could just be released 🤷 maybe we shouldn't for consistency. Probably worth a discussion we can't do this because we're going to be passing --tag alpha to the pnpm release-plan release command in the release workflow. Keep them the same for now
  • I made webpack private so it won't release
  • I had to remove webpack as a peer of test-setup because it was breaking the plan process (understandably) test-setup is now private and I haven't changed its dependencies
  • I made test-setup private since we don't know how to create it for a post-vite world (yet)

@mansona mansona marked this pull request as draft February 11, 2025 12:42
@mansona mansona force-pushed the pre-release branch 2 times, most recently from 6708d5b to 80e8e4d Compare February 11, 2025 12:47
Base automatically changed from update-release-plan to main February 11, 2025 12:48
@mansona mansona force-pushed the pre-release branch 2 times, most recently from 56e8977 to 713ab4e Compare February 11, 2025 15:43
@mansona mansona marked this pull request as ready for review February 11, 2025 15:48
@ef4 ef4 merged commit 8d39886 into main Feb 11, 2025
216 checks passed
@ef4 ef4 deleted the pre-release branch February 11, 2025 17:09
@github-actions github-actions bot mentioned this pull request Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants