No more wildcard imports and general import cleanup #4978
Closed
+94
−79
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if wildcard imports are wanted or not, but this removes them and also changes it to warnings.
In addition, there are a number of fixes where the "correct" import location is used for
emath
andColor32
. That is, the re-exports are not used. Again, I do not know the stance of this, but to keep things consistent in the code base and possibly simplify deprecating the re-exports etc now that there are multiple crates.Edit: Seems only half-finished, but any input if I should finish it is appreciated.