Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No more wildcard imports and general import cleanup #4978

Closed
wants to merge 3 commits into from

Conversation

oscargus
Copy link
Contributor

@oscargus oscargus commented Aug 18, 2024

  • I have followed the instructions in the PR template

Not sure if wildcard imports are wanted or not, but this removes them and also changes it to warnings.

In addition, there are a number of fixes where the "correct" import location is used for emath and Color32. That is, the re-exports are not used. Again, I do not know the stance of this, but to keep things consistent in the code base and possibly simplify deprecating the re-exports etc now that there are multiple crates.

Edit: Seems only half-finished, but any input if I should finish it is appreciated.

Sorry, something went wrong.

@oscargus oscargus requested a review from Wumpf as a code owner August 18, 2024 09:29
@oscargus oscargus marked this pull request as draft August 18, 2024 09:35
@oscargus
Copy link
Contributor Author

Closing and adding parts in separate PRs. Will cause too many conflicts and probably wildcard imports are wanted every now and then...

@oscargus oscargus closed this Aug 18, 2024
@oscargus oscargus deleted the clippy branch August 18, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant