Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: increase the size of button_padding.y in ui.horizontal(), the widgets will create a step layer. #5040

Closed
wants to merge 4 commits into from

Conversation

rustbasic
Copy link
Contributor

@rustbasic rustbasic commented Aug 30, 2024

This commit is an example showing that issue is solved.

Dear emilk.

This commit is an example showing that issue is solved.
This way, issues are resolved and it is difficult to find new and strange places.
I don't know what effect it has on Grid or Layout::Center etc.
I didn't check if allocate_new_ui() handles this.

In Button : allocate_at_least() -> allocate_response() -> allocate_space() -> allocate_space_impl() -> placer.justify_and_align().

In Horizontal : horizontal() -> horizontal_with_main_wrap_dyn() -> allocate_ui_with_layout_dyn() -> placer.justify_and_align()

looks like justify_and_align() is being called twice.

@rustbasic rustbasic closed this Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

increase the size of button_padding.y in ui.horizontal(), the widgets will create a step layer.
1 participant