Fix: increase the size of button_padding.y in ui.horizontal(), the widgets will create a step layer. #5040
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is an example showing that issue is solved.
Related Fix: Positioning issues with Slider and other Button. #4937
Related Improvement: Apply
button_padding
anddrag_value_text_style
applied in Slider., #5027Closes increase the size of
button_padding.y
inui.horizontal()
, the widgets will create a step layer. #5029Dear emilk.
This commit is an example showing that issue is solved.
This way, issues are resolved and it is difficult to find new and strange places.
I don't know what effect it has on
Grid
orLayout::Center
etc.I didn't check if
allocate_new_ui()
handles this.In
Button
: allocate_at_least() -> allocate_response() -> allocate_space() -> allocate_space_impl() ->placer.justify_and_align()
.In
Horizontal
: horizontal() -> horizontal_with_main_wrap_dyn() -> allocate_ui_with_layout_dyn() ->placer.justify_and_align()
looks like
justify_and_align()
is being called twice.