Add opt-out fragile-send-sync-non-atomic-wasm feature for wgpu
#5098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mics on wasm with egui and wgpu.
9SMTM6
force-pushed
the
wasm_atomics_wgpu
branch
from
c3ea6ae to
2d0c1cf
Compare
Wumpf
requested changes
Sep 11, 2024
9SMTM6
commented
Sep 11, 2024
Wumpf
approved these changes
Sep 12, 2024
emilk
changed the title
fragile-send-sync-non-atomic-wasm feature for wgpu
Co-authored-by: Andreas Reich <[email protected]>
|
@Wumpf done. Thanks for catching the somewhat embarrassing oversight in the actual source code ;-P. |
|
Thanks for taking the time @Wumpf! |
|
@emilk this was in the release yesterday, was it not? Just asking because I would like to remove my patch to the master branch, this is a bit annoying. When I checked the changelog it wasn't mentioned, but when I look at the respective git tag it seems to be present. |
|
it's part of the release 👍 |
hacknus
pushed a commit
to hacknus/egui
that referenced
this pull request
Oct 30, 2024
…lk#5098) Note this will break people depending on eframe or egui-wgpu with --no-default-features. I don't know what to do about that to be honest. * Closes emilk#4914 * [x] I have followed the instructions in the PR template --------- Co-authored-by: Andreas Reich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note this will break people depending on eframe or egui-wgpu with --no-default-features.
I don't know what to do about that to be honest.