Fix DragValue range clamping
#5118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
force-pushed
the
emilk/fix-clamp-value
branch
from
304525e to
728ad87
Compare
emilk
changed the title
.clamp_to_range with .clamp_existing_to_rangeDragValue range clamping
hacknus
pushed a commit
to hacknus/egui
that referenced
this pull request
Oct 30, 2024
When using a `DragValue`, there are three common modes of range clamping that the user may want: A) no clamping B) clamping only user input (dragging or editing text), but leave existing value intact C) always clamp The difference between mode B and C is: ```rs let mut x = 42.0; ui.add(DragValue::new(&mut x).range(0.0..=1.0)); // What will `x` be here? ``` With this PR, we now can get the three behaviors with: * A): don't call `.range()` (or use `-Inf..=Inf`) * B) call `.range()` and `.clamp_existing_to_range(false)` * C) call `.range()` ## Slider clamping Slider clamping is slightly different, since a slider always has a range. For a slider, there are these three cases to consider: A) no clamping B) clamp any value that the user enters, but leave existing values intact C) always clamp all values Out of this, C should probably be the default. I'm not sure what the best API is for this yet. Maybe an `enum` 🤔 I'll take a pass on that in a future PR. ## Related * emilk#4728 * emilk#4881 * emilk#4882
hacknus
pushed a commit
to hacknus/egui
that referenced
this pull request
Oct 30, 2024
This deprecates `.clamp_to_range` in favor of more control using `.clamping`. ## Related * emilk#4728 * Closes emilk#4881 * emilk#4882 * emilk#5118
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a
DragValue, there are three common modes of range clamping that the user may want:A) no clamping
B) clamping only user input (dragging or editing text), but leave existing value intact
C) always clamp
The difference between mode B and C is:
With this PR, we now can get the three behaviors with:
.range()(or use-Inf..=Inf).range()and.clamp_existing_to_range(false).range()Slider clamping
Slider clamping is slightly different, since a slider always has a range.
For a slider, there are these three cases to consider:
A) no clamping
B) clamp any value that the user enters, but leave existing values intact
C) always clamp all values
Out of this, C should probably be the default.
I'm not sure what the best API is for this yet. Maybe an
enum🤔I'll take a pass on that in a future PR.
Related
clamp_to_rangeoption to DragValue, renameclamp_rangetorange(deprecating the former) #4728clamp_to_range_on_dragoption toDragValueandclamp_to_range_on_value_dragoption toSlider#4882