Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix include_{xy} issue when auto bounds is off #74

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix include_{xy} issue when auto bounds is off #74

wants to merge 1 commit into from

Conversation

joaofl
Copy link

@joaofl joaofl commented Feb 5, 2025 •
edited
Loading

Re-open the following PR originally open by @aholtzma-am:
emilk/egui#4539 (comment)

The logic for determining bounds was not using the values supplied by include_x()/include_y() after the initial plot call when auto_bounds() was false. This change forces the use of the manual limits when default_auto_bounds is false.

Closes #25

I did not try the suggested approach (emilk/egui#4539 (comment)), as I would need some more in-depth understanding before risking breaking other stuff.

Maybe, with some support, I could try to implement that approach in a separate PR.

@joaofl joaofl changed the title Joao/fix include xy issue with auto bounds off Fix include_{xy} issue when auto bounds is off Feb 5, 2025
@joaofl joaofl mentioned this pull request Feb 5, 2025
Open
@joaofl joaofl force-pushed the joao/fix-include-xy-issue-with-auto-bounds-off branch from cdf9be2 to f687518 Compare February 13, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

egui_plot 0.25.0 - No auto_bounds + include_X/Y does not render anything until double click
1 participant
@joaofl