-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Spark Vector #136
Remove Spark Vector #136
Conversation
Always happy to remove stuff, but it doesn't run with Flink or Spark (some weird compilation error). |
Hmm...I can't reprocude it with How/where did you get the error? |
|
OK, I see it now. Will investigate! |
The tests pass now. I would like to rewrite parts of Kmeans using breeze.numerics.pow() but using it makes compilation fail with:
|
The problem is that we're still doing the |
@fschueler Felix, can you rewrite the Algorithm assembly code @joroKr21 suggests? |
I will give it a try! Should I open a new issue and PR for that or reopen the old typecheck/untypecheck issue? |
You can include the commit as part of this PR. As this fix is required for the replacement of the vector implementation, I guess it makes sense to prepend it, so we have a commit history which transitions from consistent to consistent state. |
The problem seems related to this PR, but we didn't manage to compile with 2.12-M3. |
Should we merge this without the changes in the |
@fschueler yes, we can do that, but please open a separate issue for the Breeze problem that summarizes the findings from this PR. |
@aalexandrov done: #152 |
Merged via 76b22ee |
This removes the Spark Vector and the XORShift (since the vector was the only class depending on it).
The Kmeans is adjusted to use breeze DenseVectors.