-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix dialyzer failures. #244
base: master
Are you sure you want to change the base?
Conversation
thank you @jimsynz |
@zmstone I'm not sure that it's possible. |
-if(?OTP_RELEASE < 27). |
Aha! This is why we don't get Elixirists to write Erlang :) I'll update the PR. |
09b1ee1
to
670641b
Compare
@zmstone good to go for your review. Cheers! |
@@ -33,7 +33,7 @@ | |||
|
|||
-type(sockname() :: {inet:ip_address(), inet:port_number()}). | |||
|
|||
-type(option() :: gen_tcp:connect_option() | {ssl_opts, [ssl:ssl_option()]}). | |||
-type(option() :: gen_tcp:connect_option() | {ssl_opts, [ssl:tls_option()]}). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need same fix here ?
Hi there.
Running dialyzer on an Elixir project which has
emqtt
as a dependency results in the following dialyzer failures:The SSL one is easy to fix - there is no
ssl:ssl_option
(or at least not anymore), but there isssl:tls_option
.The other failure is because the
emqx_types
module doesn't exist. I found it inside theemqx
app source, butemqx
is not listed as a project dependency. I'm open to suggestions on how to fix that.