Updated mysql version to 8.0 #117
Open
+21,782
−15,476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Asset group is already an instance variable so lets avoid passing it around.
Trying to clear up this file a little bit before working with it.
The URL helper was trying to generate a patch to an image/js asset not the assets controller. It was pumping out warnings and empty urls.
This now happens automatically
This method was misleadingly named.
These are unlikely to make significant improvements but should make the cops happy
These changes result in a 20 fold speed-up, taking the operation down to about 3s when query-logging is disabled. There is still scope for improvement, but I want to move on to the other bottlenecks for now.
- Add webmock to block calls in future - Mock the SS calls, rather than higher level
Still slow, and I need to evaluate the behaviour of tube racks as we're not including receptacles/racked tubes when loading in bulk
These changes result in a 20 fold speed-up, taking the operation down to about 3s when query-logging is disabled. There is still scope for improvement, but I want to move on to the other bottlenecks for now.
I had had hoped that I might just be able to use the auto-correct, but there were a few places where this was still resulting in sub-optimal behaviour.
I want to extend some of the tests to cover the newer mass import functionality that I'd previously only covered with integration tests. This should help me nail the tube rack import issues.
- Extend the import tests to cover more functionality - Ensure tube racks can load their tubes - Ensure existing assests will 'refresh'
The comment here had been rendered inaccurate via the changes I had been making. So this refactors the existing code and ensures we create the same facts as the previous path.
Bump globalid from 1.0.0 to 1.0.1
…-js-0.7.33 Bump ua-parser-js from 0.7.28 to 0.7.33
Bumps [sanitize](https://github.com/rgrove/sanitize) from 6.0.0 to 6.0.1. - [Release notes](https://github.com/rgrove/sanitize/releases) - [Changelog](https://github.com/rgrove/sanitize/blob/main/HISTORY.md) - [Commits](rgrove/sanitize@v6.0.0...v6.0.1) --- updated-dependencies: - dependency-name: sanitize dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
[ruby] Update all Bundler dependencies (2022-10-28)
Bump sanitize from 6.0.0 to 6.0.1
Extraction feb dep update
Dpl 785 remove old releases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.