Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Allow main.js for storybook to be overridden by the project theme #16

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

callinmullaney
Copy link
Collaborator

@callinmullaney callinmullaney commented Jul 22, 2024

This PR does the following:

  • Set up a default main.js that is consumed by Emulsify Core and gives an example of storybook config.

Related Issue(s)

  • None

Functional Testing:

  • Setup a new theme or add this file to an existing Emulsify 5.x project
  • Update Emulsify Core to 1.x
  • Uncomment the provided configOverrides and implement a config change. Example: add the following after the docs: {}
managerHead: (head) => `
    ${head}
    <style>
      :root {
        --colors-emulsify-blue-100: #e6f5fc;
        --colors-emulsify-blue-200: #CCECFA;
        --colors-emulsify-blue-300: #99D9F4;
        --colors-emulsify-blue-400: #66c5ef;
        --colors-emulsify-blue-500: #33b2e9;
        --colors-emulsify-blue-600: #009fe4;
        --colors-emulsify-blue-700: #007FB6;
        --colors-emulsify-blue-800: #005f89;
        --colors-emulsify-blue-900: #00405b;
        --colors-emulsify-blue-1000: #00202e;
        --colors-purple: #8B1E7E;
      }
    </style>
  `,
  • Run npm run develop to startup storybook. Inspect the main <head> of the source and verify the inline styles defined above are now rendered on the page.

┆Issue is synchronized with this Clickup task by Unito

Callin Mullaney added 2 commits July 22, 2024 08:34
…-main-storyboook-overrides

* 'main' of github.com:emulsify-ds/emulsify-core:
  chore(deps): bump sass from 1.75.0 to 1.77.8
  chore(deps): bump lint-staged from 15.2.2 to 15.2.7
  chore(deps): bump react-dom from 18.2.0 to 18.3.1
  chore(deps): bump css-loader from 7.1.1 to 7.1.2
  chore(deps): bump ramda from 0.29.1 to 0.30.1
@callinmullaney callinmullaney merged commit 07f5934 into main Jul 22, 2024
1 check passed
Copy link

🎉 This issue has been resolved in version 1.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant