Filter BEM function classes to conform to CSS spec #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes/implements the following bugs/features
bem
function to conform to the CSS class specifications listed here: https://www.w3.org/TR/CSS21/syndata.html#charactersmy^selector
would outputmy selector
as the class names.Explain the motivation for making this change. What existing problem does the pull request solve?
Class names should conform to the CSS specification and this function is outputting generated classes. Each of these generated classes should behave within the spec.
Documentation update (required)
Documentation should be added for the
bem
function.How to review this pull request
npm run storybook
bem
function, pass in some class names that are and aren't valid, for example:^
,%
, and()
with spaces.good-class-name
andwith_underscore
are unmodified.2text-field
and verify that the2
gets stripped out.┆Issue is synchronized with this Clickup task by Unito