Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon component #9

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Icon component #9

wants to merge 4 commits into from

Conversation

robherba
Copy link
Contributor

Summary

Adds an icon component.

How to review this pull request

  • Run npm run develop
  • Go to the icon component page: /story/components-icon
  • Feel free to comment, suggest changes or improvements.
image

@robherba robherba changed the title Wc icons Icon Component Nov 29, 2023
@robherba robherba changed the title Icon Component Icon component Nov 29, 2023
@robherba robherba self-assigned this Nov 29, 2023
Copy link
Contributor

@mariannuar mariannuar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🥳

@@ -0,0 +1,11 @@
import { defineConfig } from 'vite';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have a vite.config.js in the repo. Please integrate this into that file to have everything in the same place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants