-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show reputation of contacts #1365
base: master
Are you sure you want to change the base?
Conversation
Nice, this looks already good! We want to go with the version from The other is only relevant for the current registration, and it does not really say anything about the total reputation. |
Thanks Chris, this is exactly what I needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far! Some minor issues, and the tests seem to be failing thought. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is some small thing on the contacts page, which I would like to have resolved. Apart from that it looks good! I can't tell why all integration tests fail though just by looking at the code.
if (_contactsPageStore.isLoading) { | ||
return const Center(child: CircularProgressIndicator()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the whole contact page should be loading, but only the part holding the reputation.
@@ -283,7 +286,7 @@ class EndorseButton extends StatelessWidget { | |||
} else if (store.encointer.currentPhase != CeremonyPhase.Registering) { | |||
await _popupDialog(context, l10n.canEndorseInRegisteringPhaseOnly); | |||
} else { | |||
await submitEndorseNewcomer(context, store, api, store.encointer.chosenCid, address); | |||
await submitEndorseNewcomer(context, store, webApi, store.encointer.chosenCid, address); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I prefer it the other way. Better to pass an argument and minimize the references to globals. Or what was your thinking here?
# Conflicts: # app/lib/page/profile/contacts/contacts_page.dart # app/lib/store/settings.dart # app/pubspec_overrides.yaml
Closes #1178
This is how it looks now:
Contacts with reputations get names from here:
which comes from
webApi.encointer.getReputations(String address)
.We also have
enum ParticipantType { Bootstrapper, Reputable, Endorsee, Newbie }
which comes from
When the end result compared,
Reputation
withParticipantType
, they have conflicting information.When reputation is
participantType can be null, as in example shown below,
participantType
comes frompersonal
@clangenb HELP NEEDED HERE! Which one do I go with?
NOTE: Did local integration tests on android on two different devices, both passed. Cannot understand why not passing here in actions.