Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed take screenshot CI on IOS #1625

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Eldar2021
Copy link
Member

I thought it would be fixed with the new versions of Flutter, but I got a reply from the flutter team that flutter_driver can be deprecated. I recommend this solution until we switch to Patrol.

@Eldar2021 Eldar2021 added A2-technical PR introduces technical changes B1-medium Elevates a release containing this PR to "medium priority" C0-breaksnothing PR does not introduce any breaking changes labels Jan 27, 2024
@Eldar2021 Eldar2021 requested a review from clangenb January 27, 2024 16:53
@Eldar2021 Eldar2021 self-assigned this Jan 27, 2024
Copy link
Member

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super, thanks a lot for this simple fix. Yeah, I remember that they actually announced a long time ago that the flutter_drive is going to be removed. But the last time I looked into this, integration test was not able to do print screens at all. However, I think this has changed now.

I only have one question. :)

app/test_driver/helpers/extension/screenshot_driver.dart Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A2-technical PR introduces technical changes B1-medium Elevates a release containing this PR to "medium priority" C0-breaksnothing PR does not introduce any breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants