Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: Delete obsolete platform-compatibility-test (#2419)
Closes: #2418 Refs: #2417 #1308 ## Description Adapted from #2419 (review) below The platform compatibility test specifically validates that SES works on Node.js 12 and can be deleted since it has vanished into history. Node.js 12 required special consideration because of its experimental ESM support. Delete the `test:platform-compatibility` script in the ses `package.json`, as well as the `test/package` fixture in ci.yml Immediate motivation explained in #2418 , #2417 broken the platform-compatibility-test tests because it depends on the platform providing either `Array.prototype.transfer` or `structuredClone`. Node supports `transfer` starting with Node 22, but supports `structuredClone` starting in Node 18. That should be fine, since that is our declared support floor. This PR changes our one known remaining dependence on Node 12. ### Security Considerations none ### Scaling Considerations none ### Documentation Considerations none beyond the need to explain our platform requirements, which this PR does not change. ### Testing Considerations The point. This PR only affects tests, not production code. Reviewers, should this PR be labeled `test:` instead of `fix:`? ### Compatibility and Upgrade Considerations After this PR, we will no longer notice further breakage on Node < 18. That fits with our declared support floor.
- Loading branch information