-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix (build): Add (initial) missing CI test coverage for DevEnv 🫙 #517
base: main
Are you sure you want to change the base?
Conversation
As is, this currently fails on CI, due to:
and I'm sure yet why... ideas welcome! |
19b92ee
to
c511fb0
Compare
duh! That was just because the I've made it conditional now - that should hopefully do the trick... |
Hm, but this will add 3m 41s to EVERY (no caching?!) build... I'm not entirely sure yet if I'm a huge fan of this. |
No, wait a second, this adds >10' to every build! That's... really not great. I would love to (have someone else?) further investigate 🔢 if there isn't a smart way to "cache Docker" (layers) on Actions, before merging this. |
https://docs.docker.com/build/cache/backends/gha/ ? Seems simple enough... But with hopefully we don't hit the 10 GB limit... |
c511fb0
to
8b6bf5b
Compare
Relates to #458