Allow choosing a custom directory for local backups

[victor-marino]

Pull request (PR) checklist

Please check if your pull request fulfills the following requirements:

• I've read and understand the Code Contributions Guide.
• I confirm that I've run the code locally and everything works as expected.

What's changed?

As discussed in #268, we'd like to make incremental improvements to the backup & export functionality, ultimately leading to the implementation of automated, scheduled backups (hopefully in the cloud as well as locally).

The first step towards this goal should be to offer the user the option to choose a custom directory when making a manual backup.

This doesn't close the above issue, it just contributes to it.

Couple of things to note:

Removal of getDownloadPath()

Since we're now allowing the user to choose where to save the exports, both .exportDatabaseFile() and .exportSpreadsheet() methods take the path as an argument and no longer need to figure it out by themselves. Therefore, I think we will no longer need the getDownloadPath() function and I've deleted it.

This has the added benefit of removing the need to find a valid cross-platform "default" path, which is not trivial and introduces a few problems (e.g.: only the /Downloads directory truly works across platforms, but for some reason Android's FilePicker() dialogue does NOT allow the user to select it... which can be confusing).

Of course let me know if you prefer to keep it.

New names

I have taken the liberty of renaming a couple of symbols in a way that I think will make more sense once we start implementing the rest of features:

• downloadDatabaseFile() -> exportDatabaseFile()
• downloadPath -> exportPath

Of course feel free to revert that if you disagree.

Does this PR close any GitHub issues? (do not delete)

---

[enrique-lozano]

Thanks, I will test it once the conflicts are resolved :)

[victor-marino]

Thanks, I will test it once the conflicts are resolved :)

Ah sorry, had missed that!

Conflict solved ;-)

[victor-marino]

My apologies. Just realized I wasn't correctly handling the case where the user cancels the file picker.

Fixed in the last commit, and simplified the code a bit as a result.

[enrique-lozano]

Hi @victor-marino! I've taken the liberty of making some quick changes to your PR. Nothing too relevant to your code, just more things that needed to be improved that were already there.

I've tested your code and it works fine on Windows and Android, if you give me your final confirmation when you see these changes, I'll merge the PR.

[victor-marino]

Hi @victor-marino! I've taken the liberty of making some quick changes to your PR. Nothing too relevant to your code, just more things that needed to be improved that were already there.

I've tested your code and it works fine on Windows and Android, if you give me your final confirmation when you see these changes, I'll merge the PR.

Yep, all looks good to me! Go ahead with the merge.