Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove magic numbers from SQL generation #12141

Merged
merged 6 commits into from
Jan 27, 2025
Merged

Remove magic numbers from SQL generation #12141

merged 6 commits into from
Jan 27, 2025

Conversation

AdRiley
Copy link
Member

@AdRiley AdRiley commented Jan 24, 2025 •
edited
Loading

Pull Request Description

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

https://github.com/enso-org/enso/actions/runs/12988263393

Snowflake tests passed

@AdRiley AdRiley added the CI: No changelog needed Do not require a changelog entry for this PR. label Jan 24, 2025
radeusgd
radeusgd approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@radeusgd radeusgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect! ❤️

@AdRiley AdRiley added the CI: Keep up to date Automatically update this PR to the latest develop. label Jan 27, 2025
@AdRiley AdRiley added CI: Ready to merge This PR is eligible for automatic merge and removed CI: Keep up to date Automatically update this PR to the latest develop. labels Jan 27, 2025
@mergify mergify bot merged commit 5f53340 into develop Jan 27, 2025
46 checks passed
@mergify mergify bot deleted the wip/adr/remove-magic-numbers branch January 27, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GregoryTravis GregoryTravis GregoryTravis approved these changes

@radeusgd radeusgd radeusgd approved these changes

@jdunkerley jdunkerley Awaiting requested review from jdunkerley jdunkerley is a code owner

@marthasharkey marthasharkey Awaiting requested review from marthasharkey marthasharkey is a code owner

Assignees
No one assigned
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AdRiley @radeusgd @GregoryTravis