Add test reshare e2e to ci on release #1304
Conversation
There was a problem hiding this comment.
⭐
Great to have this in.
One nitpick: we could put this at the beginning of the main release pipeline so that the release will only get built if this passes.
Can we try this out by tagging this with test/release/test-release-workflow?
.github/workflows/test-resahre-e2e
Outdated
|
|
||
| jobs: | ||
| test-e2e-reshare: | ||
| runs-on: ubuntu-latest |
There was a problem hiding this comment.
Just in case you are not aware - ubuntu-latest will give us a standard github runner. Our other tests run on core-build-runner which has much better specs. This might be needed to do a release build - i think the standard runners only have like 14gb storage.
.github/workflows/test-resahre-e2e
Outdated
| - test/**release/** | ||
| schedule: | ||
| # Build the default branch weekly. Our version of "nightly." | ||
| - cron: 55 4 * * 0 # Every Sunday at 4:55 AM. |
There was a problem hiding this comment.
I don't understand what the schedule is for
There was a problem hiding this comment.
Agree, I think this should be removed if this is running as its own action. If this gets added to our main release pipeline, per peg's comment, the schedule in that yaml file should remain.
There was a problem hiding this comment.
yup sounds good, was just following the other release convention
.github/workflows/test-resahre-e2e
Outdated
| - test/**release/** | ||
| schedule: | ||
| # Build the default branch weekly. Our version of "nightly." | ||
| - cron: 55 4 * * 0 # Every Sunday at 4:55 AM. |
There was a problem hiding this comment.
Agree, I think this should be removed if this is running as its own action. If this gets added to our main release pipeline, per peg's comment, the schedule in that yaml file should remain.
| @@ -5,9 +5,6 @@ tagged as the final release. | |||
|
|
|||
| ## Pre-Prep | |||
| - [ ] Inform relevant parties that you're preparing a release (e.g, by posting on Discord) | |||
| - [ ] Manually run e2e reshare test | |||
There was a problem hiding this comment.
Would it be useful to update this to mention the tests are running as part of our pipeline, or that the tests are release blocking, if you go with Peg's good advice?
| run: | | ||
| pushd node | ||
| cargo build --release --features=reshare-test | ||
| cargo test -p entropy-tss --release -- --test_reshare_e2e |
There was a problem hiding this comment.
Should this not be:
| cargo test -p entropy-tss --release -- --test_reshare_e2e | |
| cargo test -p entropy-tss --release test_reshare_e2e |
There was a problem hiding this comment.
both work but also looks like I need to add --features=reshare-test
|
About to delete the release pipeline but can confirm it is tested and works https://github.com/entropyxyz/entropy-core/actions/runs/13417074322/job/37480419216 |
…-reshare-e2e-on-release
Closes #1270
Adds the e2e test to the release check pipeline