Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send/Sync adjustment #92

Merged
merged 3 commits into from
Feb 10, 2025
Merged

Send/Sync adjustment #92

merged 3 commits into from
Feb 10, 2025

Conversation

fjarri
Copy link
Member

@fjarri fjarri commented Feb 10, 2025

  • Remove Send + Sync bound from WireFormat
  • Remove Send bound on ProtocolError

Closes #13. Seems like this is as much as we can do. Since Rounds are boxed, we can't add Send + Sync bounds on them in public API signatures. Same goes for Payloads and Artifacts. This only really leaves Protocol's and SessionParameterss associated types. PartyId is left Send + Sync because it is used in Round implementations, and specifying that bound every time would just be too much boilerplate.

@fjarri fjarri merged commit 9810d01 into entropyxyz:master Feb 10, 2025
8 checks passed
@fjarri fjarri deleted the send-sync branch February 10, 2025 20:06
@coveralls
Copy link

coveralls commented Feb 13, 2025

Pull Request Test Coverage Report for Build 13249231959

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 10 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 73.299%

Files with Coverage Reduction New Missed Lines %
manul/src/session/tokio.rs 10 88.05%
Totals Coverage Status
Change from base Build 13248845649: -0.02%
Covered Lines: 2273
Relevant Lines: 3101

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relax Send/Sync requirements
2 participants