Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper threshold support #95

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from
Draft

Conversation

fjarri
Copy link
Member

@fjarri fjarri commented Feb 20, 2025

Fixes #11

Done:

  • introduced quorum concept in the API, using it for normal rounds

TODO:

  • a method of IdSet that would tell us if quorum can never be reached given the already banned nodes
  • don't expect messages from a node if it was already banned in the previous round
  • support threshold in the echo round, and figure out what CommunicationInfo should be like for that
  • generalize IdSet to be a trait, allowing users to specify their own quorum conditions?
  • depending on how the echo round is handled, may be able to close Decouple protocol and session levels #25?

@coveralls
Copy link

coveralls commented Feb 20, 2025

Pull Request Test Coverage Report for Build 13447280574

Details

  • 196 of 268 (73.13%) changed or added relevant lines in 10 files are covered.
  • 10 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.8%) to 72.643%

Changes Missing Coverage Covered Lines Changed/Added Lines %
manul/src/combinators/misbehave.rs 23 25 92.0%
manul/src/protocol/round.rs 32 34 94.12%
manul/src/session/session.rs 44 53 83.02%
manul/src/combinators/chain.rs 33 45 73.33%
manul/src/protocol/boxed_round.rs 24 38 63.16%
manul/src/session/evidence.rs 8 23 34.78%
manul/src/session/echo.rs 7 25 28.0%
Files with Coverage Reduction New Missed Lines %
manul/src/session/evidence.rs 1 53.75%
manul/src/protocol/errors.rs 3 16.09%
manul/src/session/session.rs 6 77.52%
Totals Coverage Status
Change from base Build 13401865846: -0.8%
Covered Lines: 2196
Relevant Lines: 3023

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decouple protocol and session levels Support for nodes dropping out during the protocol
2 participants