Prefer the Pow trait

.github/workflows/ci.yml

@@ -17,7 +17,7 @@ jobs:
     strategy:
       matrix:
         rust:
-          - 1.81.0 # MSRV
+          - 1.83.0 # MSRV
           - stable
         target:
           - wasm32-unknown-unknown
@@ -59,7 +59,7 @@ jobs:
       matrix:
         include:
           - target: x86_64-unknown-linux-gnu
-            rust: 1.81.0 # MSRV
+            rust: 1.83.0 # MSRV
     steps:
       - uses: actions/checkout@v4
       - uses: dtolnay/rust-toolchain@v1
@@ -77,7 +77,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions-rs/toolchain@v1
         with:
-          toolchain: 1.81.0 # MSRV
+          toolchain: 1.83.0 # MSRV
           components: clippy
           override: true
           profile: minimal

CHANGELOG.md

@@ -7,14 +7,15 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ## [0.3.0] - in development
 
 - Switch the protocol framework to `manul`. ([#156])
-
+- Bumped MSRV to 1.83 ([#176])
 
 [#156]: https://github.com/entropyxyz/synedrion/pull/156
+[#176]: https://github.com/entropyxyz/synedrion/pull/176
 
 
 ## [0.2.0] - 2024-11-17
 
-- Signature and elliptic curve dependencies reset back to stable versions. (#[154])
+- Signature and elliptic curve dependencies reset back to stable versions. ([#154])
 
 
 [#154]: https://github.com/entropyxyz/synedrion/pull/154

synedrion/Cargo.toml

@@ -3,7 +3,7 @@ name = "synedrion"
 authors = ['Entropy Cryptography <[email protected]>']
 version = "0.3.0-dev"
 edition = "2021"
-rust-version = "1.81"
+rust-version = "1.83"
 license = "AGPL-3.0-or-later"
 description = "Threshold signing library based on Canetti-Gennaro-Goldfeder-Makriyannis-Peled '21 scheme"
 repository = "https://github.com/entropyxyz/synedrion"
@@ -26,7 +26,7 @@ tracing = { version = "0.1.41", default-features = false }
 
 # Note: `alloc` is needed for `crytpto-bigint`'s dependency `serdect` to be able
 # to serialize Uints in human-readable formats.
-crypto-bigint = { version = "0.6.0-rc.6", default-features = false, features = [
+crypto-bigint = { version = "0.6.0-rc.8", default-features = false, features = [
 	"serde",
 	"alloc",
 	"rand_core",
@@ -38,6 +38,7 @@ serde = { version = "1", default-features = false, features = ["derive"] }
 serde-encoded-bytes = { version = "0.1", default-features = false, features = ["hex", "base64"] }
 bincode = { version = "2.0.0-rc.3", default-features = false, features = ["serde", "alloc"] }
 displaydoc = { version = "0.2", default-features = false }
+criterion = { version = "0.5", optional = true }
 
 [dev-dependencies]
 manul = { version = "0.1", features = ["dev"] }
@@ -50,9 +51,24 @@ k256 = { version = "0.13", default-features = false, features = ["ecdsa", "arith
 impls = "1"
 hex = { version = "0.4", default-features = false, features = ["alloc"] }
 test-log = { version = "0.2.16", default-features = false, features = ["trace", "color"] }
+tracing-subscriber = "0.3.19"
+
+[features]
+private_benches = ["criterion"]
 
 [[bench]]
 bench = true
 name = "bench"
 harness = false
 path = "benches/bench.rs"
+
+[[bench]]
+bench = true
+name = "pow"
+harness = false
+path = "benches/pow.rs"
+
+[[bench]]
+bench = true
+name = "zk_proofs"
+harness = false

synedrion/benches/pow.rs

@@ -0,0 +1,125 @@
+use criterion::{black_box, criterion_group, criterion_main, BatchSize, Criterion};
+use crypto_bigint::{
+    modular::{MontyForm, MontyParams},
+    NonZero, Odd, Random, Uint, U1024, U2048, U256, U4096, U512,
+};
+use crypto_primes::RandomPrimeWithRng;
+use rand::SeedableRng;
+
+fn bench_pow_known_totient_512(c: &mut Criterion) {
+    let mut group = c.benchmark_group("modpow, 512^1024");
+
+    let mut rng = rand_chacha::ChaCha8Rng::seed_from_u64(1234567890);
+    let p: U512 = (U256::generate_prime_with_rng(&mut rng, U256::BITS), U256::ZERO).into();
+    let q: U512 = (U256::generate_prime_with_rng(&mut rng, U256::BITS), U256::ZERO).into();
+    let m: U512 = p * q;
+    let totient = (p - U512::ONE) * (q - U512::ONE);
+    let prms = MontyParams::new_vartime(Odd::new(m).unwrap());
+
+    group.bench_function("vanilla", |b| {
+        let mut rng = rand_chacha::ChaCha8Rng::seed_from_u64(1234567890);
+        b.iter_batched(
+            || {
+                let x = U512::random(&mut rng);
+                let x = MontyForm::new(&x, prms);
+                let exponent = U1024::random(&mut rng);
+                (x, exponent)
+            },
+            |(x, exponent)| black_box(x.pow(&exponent)),
+            BatchSize::SmallInput,
+        );
+    });
+
+    group.bench_function("known totient", |b| {
+        let mut rng = rand_chacha::ChaCha8Rng::seed_from_u64(1234567890);
+        b.iter_batched(
+            || {
+                let x = U512::random(&mut rng);
+                let x = MontyForm::new(&x, prms);
+                let exponent = U1024::random(&mut rng);
+                let exponent = Uint::rem_wide_vartime(exponent.split(), &NonZero::new(totient).unwrap());
+                (x, exponent)
+            },
+            |(x, exponent)| black_box(x.pow(&exponent)),
+            BatchSize::SmallInput,
+        );
+    });
+
+    group.bench_function("known totient (not ammortized)", |b| {
+        let mut rng = rand_chacha::ChaCha8Rng::seed_from_u64(1234567890);
+        b.iter_batched(
+            || {
+                let x = U512::random(&mut rng);
+                let x = MontyForm::new(&x, prms);
+                let exponent = U1024::random(&mut rng);
+                (x, exponent)
+            },
+            |(x, exponent)| {
+                let exponent = Uint::rem_wide_vartime(exponent.split(), &NonZero::new(totient).unwrap());
+                black_box(x.pow(&exponent))
+            },
+            BatchSize::SmallInput,
+        );
+    });
+}
+
+// Our production parameters use 1024-bit primes resulting in 2048-bit moduli
+fn bench_pow_known_totient_2048(c: &mut Criterion) {
+    let mut group = c.benchmark_group("modpow, 2048^4096");
+
+    let mut rng = rand_chacha::ChaCha8Rng::seed_from_u64(1234567890);
+    let p: U2048 = (U1024::generate_prime_with_rng(&mut rng, U1024::BITS), U1024::ZERO).into();
+    let q: U2048 = (U1024::generate_prime_with_rng(&mut rng, U1024::BITS), U1024::ZERO).into();
+    let m: U2048 = p * q;
+    let totient = (p - U2048::ONE) * (q - U2048::ONE);
+    let prms = MontyParams::new_vartime(Odd::new(m).unwrap());
+
+    group.bench_function("vanilla", |b| {
+        let mut rng = rand_chacha::ChaCha8Rng::seed_from_u64(1234567890);
+        b.iter_batched(
+            || {
+                let x = U2048::random(&mut rng);
+                let x = MontyForm::new(&x, prms);
+                let exponent = U4096::random(&mut rng);
+                (x, exponent)
+            },
+            |(x, exponent)| black_box(x.pow(&exponent)),
+            BatchSize::SmallInput,
+        );
+    });
+
+    group.bench_function("known totient", |b| {
+        let mut rng = rand_chacha::ChaCha8Rng::seed_from_u64(1234567890);
+        b.iter_batched(
+            || {
+                let x = U2048::random(&mut rng);
+                let x = MontyForm::new(&x, prms);
+                let exponent = U4096::random(&mut rng);
+                let exponent = Uint::rem_wide_vartime(exponent.split(), &NonZero::new(totient).unwrap());
+                (x, exponent)
+            },
+            |(x, exponent)| black_box(x.pow(&exponent)),
+            BatchSize::SmallInput,
+        );
+    });
+
+    group.bench_function("known totient (not ammortized)", |b| {
+        let mut rng = rand_chacha::ChaCha8Rng::seed_from_u64(1234567890);
+        b.iter_batched(
+            || {
+                let x = U2048::random(&mut rng);
+                let x = MontyForm::new(&x, prms);
+                let exponent = U4096::random(&mut rng);
+                (x, exponent)
+            },
+            |(x, exponent)| {
+                let exponent = Uint::rem_wide_vartime(exponent.split(), &NonZero::new(totient).unwrap());
+                black_box(x.pow(&exponent))
+            },
+            BatchSize::SmallInput,
+        );
+    });
+}
+criterion_group!(benches, bench_pow_known_totient_512, bench_pow_known_totient_2048);
+
+criterion_main!(benches);