Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix tcp proxy coverage #38245

Merged
merged 2 commits into from
Jan 29, 2025
Merged

fix tcp proxy coverage #38245

merged 2 commits into from
Jan 29, 2025

Conversation

IssaAbuKalbein
Copy link
Contributor

Resolve #38240

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:

fix tcp proxy coverage
3975bf9 
Signed-off-by: Issa Abu Kalbein <[email protected]>
@IssaAbuKalbein
Copy link
Contributor Author

@alyssawilk please take a look

alyssawilk
alyssawilk reviewed Jan 29, 2025
View reviewed changes
Copy link
Contributor

@alyssawilk alyssawilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for jumping on this!
can you revert the change to test/per_file_coverage.sh as well?
/wait

@repokitteh-read-only RepoKitteh - Read Only
Copy link

CC @envoyproxy/coverage-shephards: FYI only for changes made to (test/per_file_coverage.sh).
envoyproxy/coverage-shephards assignee is @alyssawilk

🐱

Caused by: #38245 was synchronize by IssaAbuKalbein.

see: more, trace.

@alyssawilk alyssawilk enabled auto-merge (squash) January 29, 2025 14:28
@IssaAbuKalbein
Copy link
Contributor Author

/retest

2 similar comments
@IssaAbuKalbein
Copy link
Contributor Author

/retest

@IssaAbuKalbein
Copy link
Contributor Author

/retest

@alyssawilk alyssawilk merged commit 8584f9c into envoyproxy:main Jan 29, 2025
24 checks passed
@IssaAbuKalbein IssaAbuKalbein deleted the fix_tcp_proxy_coverage branch January 29, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyssawilk alyssawilk alyssawilk approved these changes

Assignees

@alyssawilk alyssawilk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix tcp proxy coverage
2 participants
@IssaAbuKalbein @alyssawilk