moving away from promStatsdExporterContainer

[zirain]

fixes: #3369

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.64%. Comparing base (d00737b) to head (2551b7b).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4272      +/-   ##
==========================================
- Coverage   65.67%   65.64%   -0.04%     
==========================================
  Files         197      197              
  Lines       23552    23534      -18     
==========================================
- Hits        15467    15448      -19     
- Misses       6974     6976       +2     
+ Partials     1111     1110       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[arkodg]

🎉 🎉 🎉
Thanks for driving this work across multiple repos @zirain !

[zirain]

need more work to make sure everything work as expected

[zirain]

ratelimit_service_rate_limit_over_limit{
domain="gateway-conformance-infra/same-namespace/http",
key1="httproute/gateway-conformance-infra/header-ratelimit/rule/0/match/0/*_httproute/gateway-conformance-infra/header-ratelimit/rule/0/match/0/*",
key2="rule-0-match-0_rule-0-match-0",
key3="rule-0-match-1_rule-0-match-1"} 1

this key1 is hard to read....

[zirain]

ratelimit.service.rate_limit.gateway-conformance-infra/same-namespace/http.httproute/gateway-conformance-infra/cidr-ratelimit/rule/0/match/0/*_httproute/gateway-conformance-infra/cidr-ratelimit/rule/0/match/0/*.masked_remote_address_0.0.0.0/0.remote_address.over_limit

. is a key word in statsd we should avoid to use it in descriptor.

[zirain]

ratelimit.service.rate_limit.gateway-conformance-infra/same-namespace/http.httproute/gateway-conformance-infra/cidr-ratelimit/rule/0/match/0/*_httproute/gateway-conformance-infra/cidr-ratelimit/rule/0/match/0/*.masked_remote_address_0.0.0.0/0.remote_address.over_limit

. is a key word in statsd we should avoid to use it in descriptor.

this looks like an upstream issue, need to change the upstream code.

[arkodg]

ratelimit.service.rate_limit.gateway-conformance-infra/same-namespace/http.httproute/gateway-conformance-infra/cidr-ratelimit/rule/0/match/0/*_httproute/gateway-conformance-infra/cidr-ratelimit/rule/0/match/0/*.masked_remote_address_0.0.0.0/0.remote_address.over_limit

. is a key word in statsd we should avoid to use it in descriptor.

this looks like an upstream issue, need to change the upstream code.

hey can you create a GH issue for this ?

[zhaohuabing]

LGTM thanks!