Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(default-memory-limits): set default memory limits #5032

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ryanhristovski
Copy link
Contributor

@ryanhristovski ryanhristovski commented Jan 10, 2025

Reverts #4979 and removes the shutdown manager configuration for now.

The issue for failed CI was shutdown-manager oomkilling. While I do some benchmarking on this service to determine what a good memory limit will be using this comment as a starting point #4960 (comment). I am going to go ahead and continue with the default memory limits.

Original PR: #4960

@ryanhristovski ryanhristovski force-pushed the revert-4979-revert-4960-feat-set-default-memory-limits branch from 93b5fbb to 79c5920 Compare January 10, 2025 16:17
@ryanhristovski
Copy link
Contributor Author

Not sure why DCO is failing here, but PR is ready

@ryanhristovski ryanhristovski marked this pull request as ready for review January 10, 2025 16:25
@ryanhristovski ryanhristovski requested a review from a team as a code owner January 10, 2025 16:25
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.86%. Comparing base (c499b41) to head (cc2d2b8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5032      +/-   ##
==========================================
+ Coverage   66.84%   66.86%   +0.01%     
==========================================
  Files         211      210       -1     
  Lines       32920    32950      +30     
==========================================
+ Hits        22007    22031      +24     
- Misses       9586     9587       +1     
- Partials     1327     1332       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zirain
Copy link
Member

zirain commented Jan 11, 2025

Not sure why DCO is failing here, but PR is ready

9b1f471 didn't signed.

@ryanhristovski ryanhristovski force-pushed the revert-4979-revert-4960-feat-set-default-memory-limits branch 6 times, most recently from e93118d to 9fee844 Compare January 13, 2025 19:23
@ryanhristovski
Copy link
Contributor Author

is it possible the end to end tests are flaky?

on the last build it failed on e2e-test (v1.30.6, ipv4) and passed e2e-test (v1.31.4, ipv6)... now it's failing on e2e-test (v1.31.4, ipv6) with seemingly unrelated errors

@zirain
Copy link
Member

zirain commented Jan 13, 2025

/retest

@ryanhristovski
Copy link
Contributor Author

@zirain need anything else to get this merged?

@zirain zirain force-pushed the revert-4979-revert-4960-feat-set-default-memory-limits branch from d348bea to df54ff7 Compare January 16, 2025 23:47
@zirain
Copy link
Member

zirain commented Jan 16, 2025

@ryanhristovski LGTM, please fix DCO.

@ryanhristovski ryanhristovski force-pushed the revert-4979-revert-4960-feat-set-default-memory-limits branch from df54ff7 to 44cd56c Compare January 16, 2025 23:59
@ryanhristovski
Copy link
Contributor Author

/retest

@arkodg
Copy link
Contributor

arkodg commented Jan 17, 2025

@ryanhristovski isnt this something that can be set using EnvoyProxy ?
if we are setting the requests and limits value to be equal, then we should reevaluate if 512M is the right default choice for most cases

@ryanhristovski
Copy link
Contributor Author

@arkodg yes it can be set in EnvoyProxy but not having memory limits set by default can cause cluster-wide issues that I don't think we'd want to happen unintentionally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants