-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(default-memory-limits): set default memory limits #5032
base: main
Are you sure you want to change the base?
feat(default-memory-limits): set default memory limits #5032
Conversation
93b5fbb
to
79c5920
Compare
Not sure why DCO is failing here, but PR is ready |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5032 +/- ##
==========================================
+ Coverage 66.84% 66.86% +0.01%
==========================================
Files 211 210 -1
Lines 32920 32950 +30
==========================================
+ Hits 22007 22031 +24
- Misses 9586 9587 +1
- Partials 1327 1332 +5 ☔ View full report in Codecov by Sentry. |
9b1f471 didn't signed. |
e93118d
to
9fee844
Compare
is it possible the end to end tests are flaky? on the last build it failed on |
/retest |
@zirain need anything else to get this merged? |
d348bea
to
df54ff7
Compare
@ryanhristovski LGTM, please fix DCO. |
…s " (envoyproxy#4979)" This reverts commit c6d5a54. Signed-off-by: Ryan Hristovski <[email protected]>
Signed-off-by: Ryan Hristovski <[email protected]>
Signed-off-by: Ryan Hristovski <[email protected]>
df54ff7
to
44cd56c
Compare
/retest |
@ryanhristovski isnt this something that can be set using EnvoyProxy ? |
@arkodg yes it can be set in |
Reverts #4979 and removes the shutdown manager configuration for now.
The issue for failed CI was shutdown-manager oomkilling. While I do some benchmarking on this service to determine what a good memory limit will be using this comment as a starting point #4960 (comment). I am going to go ahead and continue with the default memory limits.
Original PR: #4960