#2412 - User can't correctly save (or make a layout) to RDF/RXN reaction several products or with separate positioned molecules

[even1024]

Generic request

• PR name follows the pattern #1234 – issue name
• branch name does not contain '#'
• base branch (master or release/xx) is correct
• PR is linked with the issue
• task status changed to "Code review"
• code follows product standards
• regression tests updated

[AliaksandrDziarkach]

I think we need more comments.
Also no need to calculate x if both vertices has x > px
So I suggest something like

inline bool isPointInPolygon(const Vec2f& p, const std::vector<Vec2f>& poly)
{
    // Ray casting algorithm
    bool in = false;
    for (size_t i = 0, n = poly.size(); i < n; ++i)
    {
        size_t j = (i + 1) % n;
        if (((poly[i].y > p.y) != (poly[j].y > p.y)) && // point y between vertices and
            (((p.x > poly[i].x) && (p.x < poly[j].x)) || // both vertices are at right of point or edge is at right of point
            (p.x < (poly[i].x + (p.y - poly[i].y) * (poly[j].x - poly[i].x) / (poly[j].y - poly[i].y))))) // py < (py-y0)*dx/dy
            in = !in;
    }
    return in;
}

[AliaksandrDziarkach]

I think it should be named isNormalNegative, and comment about "check sign of normal to (edgeStart,edgeEnd),(edgeStart,point)" will be usefull

[AlexanderSavelyev]

add tests where actual undefined component (> 2 bonds). Save to rxn, save to ket (should be still saved) Add 1 for on reactant side, 1 on catalyst and 1 on product, also one for pathway reaction