Refactored to enable compiling the library with strict compilation flags #305
+708
−423
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #304
I use the leon library in another project where I compile it with these settings:
Most of the refactoring is to due to moving classes and objects that were defined in a package object file to a separate compilation unit.
I was surprised that
-Yno-imports
helps readability of the library where an unqualified type name could be misunderstood to refer to a type in leon's library instead of the scala library. For example, inleon.lang.Bag
, the unqualifiedList
type needs to refer toscala.collection.immutable.List
instead ofleon.collection.List
.