Use a more portable shebang #313
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the *bash* binary is [not always located in */bin*][0], the *leon* script doesn't always run. This change makes the script more portable, so leon will run on more systems. [0]: https://stackoverflow.com/questions/21612980
|
Tested on NixOS. |
|
Looking at the potential disadvantages of this, it seems that none really matter for Leon. 👍 |
|
It seems like we already have it in Stainless and nobody has complained yet, so it's probably fine. We still need to add it in Inox though. |
mantognini
added a commit
to epfl-lara/inox
that referenced
this pull request
Nov 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the bash binary is not always located in /bin, the leon
script doesn't always run.
This change makes the script more portable, so leon will run on more
systems.