fix: fix MTCA-EVR-300u substitutions file #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zioven , the update is related to |
jerzyjamroz
force-pushed
the
evr-300u-db-fix
branch
from
2f4bf0c
to
37e81cb
Compare
|
I have looked at the changes and tested the code, and I found no issues This can be merged from my perspective |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
evr-mtca-300u.substitutionswill generate db name like this:$(P)$(dsh=-)Out$(s=:)FP0$(ES)Src:Scale-SPBut I think this should be better,
$(P)$(dsh=-)Out$(s=:)FP0$(ES)Src$(s=:)Scale-SPThus user can have a consistent record name (e.g. no
:) by changing macrosduringdbLoadRecordsI also add more pulsers & IO and fix bug of CML waveform size.
If
ES,dshandsare empty,evr-mtca-300u.substitutionsandevr-mtca-300u.uv.substitutionsnow generate the same records.