Adding the PLL Bandwidth adjustments for EVM and EVR #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just pushed a new commits with the changes to the db files. |
|
I just found a bug in the EVR code. It is corrected and I verified that the VME register changes as expected. |
|
@hongran Looks fine, could you just squash the commits into one. I think would be better to have this change as only 1 commit. After that I can merge it. |
|
All changes are combined. |
|
Great! LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I combined a few commits from Tony's original PR.
The PLL bandwidth choice should be applicable to other card types (pcie, mtca, ...). I have tested with the VME cards.
Let me know if it works for mtca or pcie cards.
The screen updates are not in this PR. I tested it via the EPICS record.