Add the FLASH IO for the vme300 boards #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrfCommon/src/flashiocsh.cpp
Outdated
| @@ -104,7 +104,7 @@ void flashread(const char *name, int addrraw, int countraw, const char *outfile) | |||
| if(outfile) { | |||
| fstrm.open(outfile, std::ios_base::out|std::ios_base::binary); | |||
| if(fstrm.fail()) | |||
| throw std::runtime_error("Unable to open output file"); | |||
| throw std::runtime_error("Unable to open input file"); | |||
There was a problem hiding this comment.
Is that change right ?
There was a problem hiding this comment.
Thanks for finding out this mistake. This correction should be in the flashwrite function. I will make a correction on this commit.
|
This MR looks good, just let me know about that change on the flashiocsh.cpp. I will merge after that. |
I just updated the commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the flash IO for the EVM-VME-300 and EVR-VME-300.
Only cards with pci buses can have flash IO before. I just make it also available for cards with VME bus and firmware version higher than 2.0.