Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the hardware Mxc reset function for each input #170

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

hongran
Copy link
Contributor

@hongran hongran commented Jun 20, 2024

This feature allows people to use an external signal to reset the multplexed counters.
This feature is only functional with firmware version 207.11. The earlier FW had a bug.

@hongran
Copy link
Contributor Author

hongran commented Jun 20, 2024

Is there a way to rerun this check? Such errors may just be temporary. I don't see errors in my branch.
Error: retrieving gpg key timed out.
Error: Process completed with exit code 1.

@hongran
Copy link
Contributor Author

hongran commented Jun 21, 2024

refreshed the commit to trigger the auto check. No errors this time.

@jerzyjamroz jerzyjamroz self-assigned this Jun 25, 2024
@jerzyjamroz
Copy link
Contributor

jerzyjamroz commented Jun 25, 2024

@hongran , I did a test with InpFront0EnaMxcr-SP Enabled/Disabled and InpUniv0EnaMxcr-RB is always Disabled. Why it does not change?

I understand that once it is enabled, the trigger onto InpFront0 resets all MXC counters so <0..7> ?

@hongran
Copy link
Contributor Author

hongran commented Jun 25, 2024

This feature is only functional with firmware version 207.11. The earlier FW had a bug.

What is your firmware version?
This feature is only functional with firmware version 207.11. The earlier FW had a bug.
Jukka fixed it in the VME firmware. I am not sure if he updated the one for mtca.

@@ -30,3 +30,22 @@ record(ai, "$(P)FPMask-RB") {
field(DTYP, "Obj Prop uint32")
field(INP , "@OBJ=$(OBJ), PROP=FPMASK")
}

record(bo, "$(P)EnaMxcr-SP") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hongran , I think -SP could be changed to -Sel

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hongran , I think -SP could be changed to -Sel

Yes, I can make this change.

@hongran
Copy link
Contributor Author

hongran commented Jun 27, 2024

@jerzyjamroz I just changed the -SP to -Sel for that record. I force-pushed a commit so your push was overwritten. Could you make a new PR for that?

@jerzyjamroz
Copy link
Contributor

@hongran , I cannot verify this as MTCA EVM does not support it yet. I will merge it anyway as I do not see any other issue, and I do not want to block you. I will recheck it once our hardware supports that.

@jerzyjamroz jerzyjamroz merged commit 5b0c1a1 into epics-modules:master Jul 1, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants