Screen files for vme-300 EVM and EVR #187

hongran · 2024-10-02T19:58:53Z

1: Some of the existing screens (mostly subscreens) are updated: fixing version compatibility, color and size
2: Added screens and subscreens for evm-vme-300
3: Added screens and subscreens for evr-vme-300

The screens for the mtca cards are mostly intact. I made minimal size adjustments to make things fit.

jerzyjamroz · 2024-10-03T07:14:20Z

@agaget , could you test if it works fine for you?

agaget · 2024-10-03T09:23:02Z

Thanks for adding VME.
Can you please add the card in the launcher please ?

And the color doesn't work for me. Please use Macro and not directly color code. If you want a different color use your own color.def.
The macro names used try to respect established color name. For example "Header_background" already exist in default color.def
I have added "Header_2_Background"

agaget · 2024-10-03T09:25:07Z

Thanks for adding VME. Can you please add the card in the launcher please ?

And the color doesn't work for me. Please use Macro and not directly color code. If you want a different color use your own color.def. The macro names used try to respect established color name. For example "Header_background" already exist in default color.def I have added "Header_2_Background"

My bad you have used macro, but it doesn't work for me either. The color def used is in the directory.

To illustrate the difference: your bob and then mine

If you want your read and write to use the same color, you can use in you color.def something like that
Read_Background=Write_Background

hongran · 2024-10-03T15:14:07Z

Thanks for adding VME. Can you please add the card in the launcher please ?
And the color doesn't work for me. Please use Macro and not directly color code. If you want a different color use your own color.def. The macro names used try to respect established color name. For example "Header_background" already exist in default color.def I have added "Header_2_Background"

My bad you have used macro, but it doesn't work for me either. The color def used is in the directory.

To illustrate the difference: your bob and then mine

If you want your read and write to use the same color, you can use in you color.def something like that Read_Background=Write_Background

HI @agaget , my bob looks like this.

I use the same text color but the background color for read and write are different. I don't know why it didn't show different colors in your machine.
Could you let me know what version of CSSPhoebus are you using now? Let's find a solution that is compatible for both of us.

hongran · 2024-10-03T19:47:46Z

I just rebased my commits to the updated master branch and added the vme screens to the launch panel.

agaget · 2024-10-07T07:59:55Z

opi/bob/evg/_evg_mxc.bob

    <height>19</height>
-    <foreground_color>
-      <color name="Write_Foreground" red="0" green="255" blue="255">


It's not the version of Phoebus that matter. Here the problem is that you've removed the macro Write_Foreground, same on different place.

It will be something like this.

I guess I need to change the default background of the text input and text update.
Do you prefer the following style?

Do you have a specific background color for the text update and text entry? I am OK with any color as long as the contrast between the foreground and background is enough.

Thanks!

Ran Hong

I think we don't understand each other.
I don't care about the color, but I care about the respect of the color name macro.

As an example I use the file color.def there : https://github.com/epics-modules/mrfioc2/blob/master/opi/bob/color.def

If you don't know the color.def file, it's just a file where you define the code rgb of a macro. The advantage is that from a project to another if we have a different color convention, you just have to change your own color.def but not the bob files.
(the same exist with the font, but I don't use one)

In phoebus configuration file you can define which files to use there :

# Display configuration org.csstudio.display.builder.model/color_files=color.def org.csstudio.display.builder.model/font_files=font.def org.phoebus.ui/welcome=welcome.html

I have tried in the color.def in the repo to be as close as possible as the standard name to be a maximum compliant with everyone

HI @agaget ,

Indeed I didn't know that the default color can be configured in this way. I used the color.def from the repository and updated the foreground colors of the read/write fields.

Could you take a look at the commit that I just pushed?

Thanks for your instructions on defining the color macros.

Ran Hong

BTW, the reason why I removed the macro Write_Foreground in the first place was that I planned to use the default color for the text entry, which is the macro "Text". My default color.def has different colors for read and write background colors.

I like the idea to have Write_Foreground and Read_Foreground, so people have more flexibility to make their own color schemes using color.def.

agaget · 2024-10-09T11:56:31Z

opi/bob/evg/evm-mtca-300.bob

@@ -1162,10 +1133,6 @@ $(pv_value)</tooltip>
      <color name="Header_2_ForeGround" red="255" green="255" blue="255">
      </color>
    </foreground_color>
-    <line_color>
-      <color name="Header_2_Background" red="114" green="159" blue="207">


You've removed all the "Header_2_Background" please put it back.
Otherwise It uses the Macro "Grid" by default.
You can use
Header_2_Background=Grid in your color.def if you prefer the original Grid color.

If you can be compliant with that in your VME bobs, it would be perfect too.

I can add back the foreground_color section:
<foreground_color> <color name="Header_2_ForeGround" red="255" green="255" blue="255"> </color> </foreground_color>

The line_color section causes an error while loading the screen.
<line_color> <color name="Header_2_Background" red="114" green="159" blue="207"> </color> </line_color>

After saving the screen I found that cssphoebus removed this section. Seems that the group widget does not have a property line_color.

I just updated the screens so all groups have the Header_2_ForeGround as the foreground_color.

Line_color was added by a student of us few month ago, I think you are not using the last version of Phoebus. I am using Phoebus v4.7.4.
I should indicate the minimum version of the bob in the README

agaget · 2024-10-09T11:58:16Z

opi/bob/evr/_evrdlygen.bob

@@ -14,10 +13,6 @@
    <x>86</x>
    <width>37</width>
    <height>19</height>
-    <foreground_color>
-      <color name="Write_Foreground" red="0" green="255" blue="255">


same here please for Write_foreground

done in the last push.

agaget · 2024-10-10T08:02:42Z

For now still too many modifications that break previous installations.
Just go through https://github.com/epics-modules/mrfioc2/pull/187/files and you will see all the macros removed. Maybe some revert will be easier to handle

Also you've change witdh for some bob. It messes up all the other bob using them. Example for _evroutput.bob but I spot problems for other

In MTCA EVR then and now
Not a big deal but character are now way smaller, and we have to change all the width of all the ouputs

hongran · 2024-10-10T14:08:54Z

For now still too many modifications that break previous installations. Just go through https://github.com/epics-modules/mrfioc2/pull/187/files and you will see all the macros removed. Maybe some revert will be easier to handle

Also you've change witdh for some bob. It messes up all the other bob using them. Example for _evroutput.bob but I spot problems for other

In MTCA EVR then and now Not a big deal but character are now way smaller, and we have to change all the width of all the ouputs

Probably it is easier for me to keep all the files used by mtca systems intact. If I need to adapt any subscreens to the VME system, I will add a separate file. I will make this change today.

hongran · 2024-10-10T16:10:42Z

@agaget I just reverted all the files the mtca screens are using. Now in the file list there are only new files except for the launcher.

agaget · 2024-10-11T08:01:12Z

Ok now it is working well.

Last thing, which phoebus version do you use ? can you upgrade at least to 4.7.4 ?
I think it's a shame that VME and MTCA doesn't use the same "philosophy". I think it's due to the lack of the option "Line color" in your version.
See between MTCA and VME

MTCA Bob->

      <foreground_color>
        <color name="Header_2_ForeGround" red="255" green="255" blue="255">
        </color>
      </foreground_color>
      <line_color>
        <color name="Header_2_Background" red="114" green="159" blue="207">
        </color>
      </line_color>
      <background_color>
        <color name="Group_Background" red="240" green="240" blue="240">
        </color>
      </background_color>

VME Bob ->

    <foreground_color>
      <color name="Header_2_ForeGround" red="255" green="255" blue="255">
      </color>
    </foreground_color>
    <background_color>
      <color name="Group_Background" red="240" green="240" blue="240">
      </color>
    </background_color>

I think it's better if we develop on the same version of phoebus.

After I swear I will accept your merge ;)

hongran · 2024-10-15T20:31:48Z

Ok now it is working well.

Last thing, which phoebus version do you use ? can you upgrade at least to 4.7.4 ? I think it's a shame that VME and MTCA doesn't use the same "philosophy". I think it's due to the lack of the option "Line color" in your version. See between MTCA and VME

MTCA Bob->
      <foreground_color>
        <color name="Header_2_ForeGround" red="255" green="255" blue="255">
        </color>
      </foreground_color>
      <line_color>
        <color name="Header_2_Background" red="114" green="159" blue="207">
        </color>
      </line_color>
      <background_color>
        <color name="Group_Background" red="240" green="240" blue="240">
        </color>
      </background_color>
VME Bob ->
    <foreground_color>
      <color name="Header_2_ForeGround" red="255" green="255" blue="255">
      </color>
    </foreground_color>
    <background_color>
      <color name="Group_Background" red="240" green="240" blue="240">
      </color>
    </background_color>
I think it's better if we develop on the same version of phoebus.

After I swear I will accept your merge ;)

The version we are using is 4.6.6 and we are in the process of upgrading to 4.7.3. I think it supports line_color, too. I can use one of their test-build and update the files I added. Maybe some of the files can be shared now. Let me work on it and get back to you.

hongran · 2024-10-15T21:50:50Z

@agaget I just updated the files I added for the VME cards. Now the evg-seq and evr-expert files can be shared.
Please take a look at the files that I modified: the launcher, evr-expert.bob and evr-cml-pat40.bob.

Best regards!

Ran Hong

agaget

It seems nice to me !
Thanks for complying to my requests :)

agaget · 2024-10-16T07:43:01Z

@jerzyjamroz I let you merge then ?

hongran · 2024-10-16T14:34:11Z

It seems nice to me ! Thanks for complying to my requests :)

My pleasure to learn the way you handled the screens. At APS, people have been using another color scheme for a long time. With the macros it will be easy to adapt to that scheme.

jerzyjamroz self-assigned this Oct 3, 2024

jerzyjamroz added gui enhancement labels Oct 3, 2024

jerzyjamroz assigned agaget and unassigned jerzyjamroz Oct 3, 2024

hongran force-pushed the bob-dev2 branch from 7eb89cd to ae69e31 Compare October 3, 2024 19:45

agaget reviewed Oct 7, 2024

View reviewed changes

agaget reviewed Oct 9, 2024

View reviewed changes

hongran force-pushed the bob-dev2 branch from 21a2166 to 9a016f7 Compare October 9, 2024 18:11

hongran force-pushed the bob-dev2 branch from 9a016f7 to 3171132 Compare October 10, 2024 16:05

hongran force-pushed the bob-dev2 branch 2 times, most recently from 54be3e9 to 61b2e0a Compare October 15, 2024 21:46

agaget approved these changes Oct 16, 2024

View reviewed changes

adding screen files for vme-300 series cards

e6baabb

jerzyjamroz force-pushed the bob-dev2 branch from 61b2e0a to e6baabb Compare October 16, 2024 09:58

jerzyjamroz merged commit d63462a into epics-modules:master Oct 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Screen files for vme-300 EVM and EVR #187

Screen files for vme-300 EVM and EVR #187

hongran commented Oct 2, 2024

jerzyjamroz commented Oct 3, 2024

agaget commented Oct 3, 2024

agaget commented Oct 3, 2024 •

edited

Loading

hongran commented Oct 3, 2024

hongran commented Oct 3, 2024

agaget Oct 7, 2024

hongran Oct 7, 2024

agaget Oct 8, 2024 •

edited

Loading

hongran Oct 8, 2024

hongran Oct 8, 2024

agaget Oct 9, 2024

hongran Oct 9, 2024 •

edited

Loading

agaget Oct 10, 2024

agaget Oct 9, 2024

hongran Oct 9, 2024

agaget commented Oct 10, 2024

hongran commented Oct 10, 2024

hongran commented Oct 10, 2024

agaget commented Oct 11, 2024

hongran commented Oct 15, 2024

hongran commented Oct 15, 2024

agaget left a comment

agaget commented Oct 16, 2024

hongran commented Oct 16, 2024

Screen files for vme-300 EVM and EVR #187

Screen files for vme-300 EVM and EVR #187

Conversation

hongran commented Oct 2, 2024

jerzyjamroz commented Oct 3, 2024

agaget commented Oct 3, 2024

agaget commented Oct 3, 2024 • edited Loading

hongran commented Oct 3, 2024

hongran commented Oct 3, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

agaget Oct 8, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hongran Oct 9, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

agaget commented Oct 10, 2024

hongran commented Oct 10, 2024

hongran commented Oct 10, 2024

agaget commented Oct 11, 2024

hongran commented Oct 15, 2024

hongran commented Oct 15, 2024

agaget left a comment

Choose a reason for hiding this comment

agaget commented Oct 16, 2024

hongran commented Oct 16, 2024

agaget commented Oct 3, 2024 •

edited

Loading

agaget Oct 8, 2024 •

edited

Loading

hongran Oct 9, 2024 •

edited

Loading