-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cypress/update to cypress10 #267
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reducing numTestKeptinMemory for better local performance in UI
creating new branch with cypress 10 included
Adding visibility assertion on source type before clicking
Adding debug pause container
adding force click on dropdown
thehejik
reviewed
Nov 7, 2022
thehejik
reviewed
Nov 7, 2022
thehejik
reviewed
Nov 7, 2022
thehejik
approved these changes
Nov 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumping Cypress 10.
This bump has small differences between Chrome and Firefox due to problems found in actionable elements like dropdowns.
It seems FF versions after 102 not always work well in headless mode. For this reason tests running on FF have a different version compared to those running in Chrome. Also, I noticed differences when versions of Cypress are too far from the ones pre-selected for browsers so the following combinations have been observed to the most stable ones:
So this is the tested stable configuration:
STD-UI-Latest-Chrome: Cypress 10.11.0 | Chrome Chrome 105
STD-UI-Latest-Firefox: Cypress 10.9.0 | Firefox 99
Rancher-UI-1-Chrome: Cypress 10.11.0 | Chrome 100
Rancher-UI-1-Firefox: Cypress 10.11.0 | Firefox 99
Results CI (all sucessful):